Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
misc: remove NEXT_RUNTIME=edge from middleware tests (vercel#40977)
This seems to be the cause for the failure of https://github.com/vercel/next.js/actions/runs/3133433920/jobs/5087331787 that caused[ the revert](vercel#40967) of my [commit ](vercel@11deaaa) that changed the edge bundle to SSR. After investigating, I realised this was the culprit: this forces the test app code to run with this on, somehow, when built on Vercel. Removing it should fix it. Let's merge if all tests still pass? Open questions: - I'm not sure why this is/was needed, since this variable should always be inlined by webpack - furthermore, this was causing client code to run as-if on the edge? - but also, this still shouldn't happen because webpack should get rid of it ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md` ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [ ] Telemetry added. In case of a feature if it's used or not. - [ ] Errors have a helpful link attached, see `contributing.md` ## Documentation / Examples - [ ] Make sure the linting passes by running `pnpm lint` - [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
- Loading branch information