Skip to content

Commit

Permalink
feat: support isolatedModules (vega#7870)
Browse files Browse the repository at this point in the history
  • Loading branch information
sid-kap authored and BradyJ27 committed Oct 19, 2023
1 parent 6f2f089 commit 679d6f1
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 13 deletions.
6 changes: 3 additions & 3 deletions src/compositemark/index.ts
Expand Up @@ -25,9 +25,9 @@ import {
normalizeErrorBar
} from './errorbar';

export {BoxPlotConfig} from './boxplot';
export {ErrorBandConfigMixins} from './errorband';
export {ErrorBarConfigMixins} from './errorbar';
export type {BoxPlotConfig} from './boxplot';
export type {ErrorBandConfigMixins} from './errorband';
export type {ErrorBarConfigMixins} from './errorbar';

export type CompositeMarkNormalizerRun = (
spec: GenericUnitSpec<any, any>,
Expand Down
2 changes: 1 addition & 1 deletion src/spec/base.ts
Expand Up @@ -12,7 +12,7 @@ import {LayoutAlign, RowCol} from '../vega.schema';
import {isConcatSpec, isVConcatSpec} from './concat';
import {isFacetMapping, isFacetSpec} from './facet';

export {TopLevel} from './toplevel';
export type {TopLevel} from './toplevel';

/**
* Common properties for all types of specification
Expand Down
22 changes: 14 additions & 8 deletions src/spec/index.ts
Expand Up @@ -14,20 +14,26 @@ import {RepeatSpec} from './repeat';
import {TopLevel} from './toplevel';
import {FacetedUnitSpec, GenericUnitSpec, NormalizedUnitSpec, TopLevelUnitSpec, UnitSpecWithFrame} from './unit';

export {BaseSpec, LayoutSizeMixins} from './base';
export {
export type {BaseSpec, LayoutSizeMixins} from './base';
export type {
GenericHConcatSpec,
GenericVConcatSpec,
NormalizedConcatSpec
} from './concat';
export {
isAnyConcatSpec,
isHConcatSpec,
isVConcatSpec,
NormalizedConcatSpec
} from './concat';
export {GenericFacetSpec, isFacetSpec, NormalizedFacetSpec} from './facet';
export {GenericLayerSpec, isLayerSpec, LayerSpec, NormalizedLayerSpec} from './layer';
export {isRepeatSpec, RepeatSpec} from './repeat';
export {TopLevel} from './toplevel';
export {FacetedUnitSpec, GenericUnitSpec, isUnitSpec, NormalizedUnitSpec, UnitSpec} from './unit';
export type {GenericFacetSpec, NormalizedFacetSpec} from './facet';
export {isFacetSpec} from './facet';
export type {GenericLayerSpec, LayerSpec, NormalizedLayerSpec} from './layer';
export {isLayerSpec} from './layer';
export type {RepeatSpec} from './repeat';
export {isRepeatSpec} from './repeat';
export type {TopLevel} from './toplevel';
export type {FacetedUnitSpec, GenericUnitSpec, NormalizedUnitSpec, UnitSpec} from './unit';
export {isUnitSpec} from './unit';

/**
* Any specification in Vega-Lite.
Expand Down
2 changes: 2 additions & 0 deletions test/jest.overrides.ts
Expand Up @@ -11,3 +11,5 @@ console.warn = function (msg: string, msg2: string) {
warn.apply(console, arguments);
throw new Error(`${msg}: ${msg2} -- Please remove unnecessary errors or use log.wrap to consume reasonable errors`);
};

export {};
3 changes: 2 additions & 1 deletion tsconfig.build.json
Expand Up @@ -5,7 +5,8 @@
"noEmit": false,
"declaration": true,
"declarationMap": true,
"sourceMap": true
"sourceMap": true,
"isolatedModules": true
},
"include": []
}
1 change: 1 addition & 0 deletions tsconfig.json
Expand Up @@ -14,6 +14,7 @@
"preserveConstEnums": true,
"resolveJsonModule": true,
"suppressImplicitAnyIndexErrors": true,
"isolatedModules": true,
"lib": ["ESNext.Array", "DOM", "DOM.Iterable"],
"noEmit": true
},
Expand Down

0 comments on commit 679d6f1

Please sign in to comment.