fix: set binSuffix for defined channel (vega#7973)

Co-authored-by: Paul Rosenzweig <paul.a.rosenzweig@gmail.com> Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
BradyJ27 · Oct 19, 2023 · 9a45757 · 9a45757
1 parent 1d48060
commit 9a45757
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/compile/mark/encode/defined.ts b/src/compile/mark/encode/defined.ts
@@ -30,7 +30,7 @@ function allFieldsInvalidPredicate(
     const scaleComponent = model.getScaleComponent(channel);
     if (scaleComponent) {
       const scaleType = scaleComponent.get('type');
-      const field = model.vgField(channel, {expr: 'datum'});
+      const field = model.vgField(channel, {expr: 'datum', binSuffix: model.stack?.impute ? 'mid' : undefined});
 
       // While discrete domain scales can handle invalid values, continuous scales can't.
       if (field && hasContinuousDomain(scaleType)) {

diff --git a/test/compile/mark/area.test.ts b/test/compile/mark/area.test.ts
@@ -53,6 +53,10 @@ describe('Mark: Area', () => {
     it('should use bin_mid for x', () => {
       expect(props.x).toEqual({field: 'bin_maxbins_10_IMDB_Rating_mid', scale: 'x'});
     });
+
+    it('should use bin_mid for the defined check', () => {
+      expect(props.defined['signal']).toContain('bin_maxbins_10_IMDB_Rating_mid');
+    });
   });
 
   describe('vertical area, with zero=false', () => {