Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

none: some tiny code tidy-up #34

Merged
merged 1 commit into from
Jun 1, 2024
Merged

none: some tiny code tidy-up #34

merged 1 commit into from
Jun 1, 2024

Conversation

Shane-XB-Qian
Copy link
Contributor

No description provided.

@Shane-XB-Qian
none: some tiny code tidy-up
6bb5a50 
Signed-off-by: shane.xb.qian <shane.qian@foxmail.com>
@Breeze0806
Copy link
Owner

Breeze0806 commented Apr 10, 2024 •
edited

Thank you so much for your PR! It's truly helpful, especially for replacing the deprecated ioutil package with the fs package in the code. If you could kindly merge this PR with #35, I would greatly appreciate it.

@Shane-XB-Qian
Copy link
Contributor Author

If you could kindly merge this PR with #35

#35 is for db2 dev env, actually to me, it maybe more useful.
as for this one, i may push similar PR like this one later, i may look into this code base more, later.

@Breeze0806 Breeze0806 merged commit 4f62855 into Breeze0806:main Jun 1, 2024
6 checks passed
@Shane-XB-Qian Shane-XB-Qian deleted the none_some_code_tidyup branch June 2, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Shane-XB-Qian @Breeze0806