Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Migrate to expo #1177

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

WIP: Migrate to expo #1177

wants to merge 1 commit into from

Conversation

youngkidwarrior
Copy link
Collaborator

@youngkidwarrior youngkidwarrior commented Aug 21, 2023

This is an exploratory PR about migrating the BrightID app to expo. I basically patched it together to get it compiling and haven't taken any steps to fix anything. Some things are broken.

The main reasonings for moving to expo are as follows:

  • Much simpler to upgrade to new versions of react native (expo upgrade)
  • Easier interop with app stores. EAS Build, EAS Push, EAS Submit. Should save us a lot of time
  • More easily shareable testing environment for dev branch with Expo Go
  • Better DX experience with Expo Go and no native compile step (removes gradle and Podfile)
  • Proper CI/CD using EAS build

Switching to expo should help BrightID spend less time with react native bugginess and App store updates and more time building the app. It's a massive pain to switch, so I understand pushback, but it would be a massive boost to long run productivity and app health

Here is a checklist of definitely broken things (there may be more):

  • keychainAdapter
  • ChangePasswordModal
  • fsStorageAdapter
  • No support for fetch-blob
  • Push Notifications
  • Localization
  • React Navigation TS Errors
  • Tests: Haven't dared to run these yet
  • Possible: DisplayName was deprecated. Switch to firstName + lastName.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant