Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US139401 chore: add commitlint config #83

Merged
merged 2 commits into from May 19, 2022

Conversation

jorge-ramirez-arredondo
Copy link
Collaborator

US139401

This adds a basic commitlint configuration to the project using config-conventional.

2022-05-18 1

@jorge-ramirez-arredondo jorge-ramirez-arredondo requested a review from a team as a code owner May 19, 2022 14:12
lweber-d2l
lweber-d2l previously approved these changes May 19, 2022
@lweber-d2l
Copy link
Contributor

Sauce tests are erroring; I don't see how this could be caused by the commit linter.
https://github.com/BrightspaceUILabs/wizard/runs/6509109045?check_suite_focus=true

@jorge-ramirez-arredondo
Copy link
Collaborator Author

Sauce tests are erroring; I don't see how this could be caused by the commit linter. https://github.com/BrightspaceUILabs/wizard/runs/6509109045?check_suite_focus=true

I dug into it a bit deeper, and it looks like it is related. It sounds like a package that's being installed by @commitlint/cli (ts-node) has some conflicts with karma (found a thread related to this: just-jeb/angular-builders#1046).

Looks like forcing ts-node to run with an earlier version works for now. I hope it gets fixed soon though.

@lweber-d2l
Copy link
Contributor

Sauce tests are erroring; I don't see how this could be caused by the commit linter. https://github.com/BrightspaceUILabs/wizard/runs/6509109045?check_suite_focus=true

I dug into it a bit deeper, and it looks like it is related. It sounds like a package that's being installed by @commitlint/cli (ts-node) has some conflicts with karma (found a thread related to this: just-jeb/angular-builders#1046).

Looks like forcing ts-node to run with an earlier version works for now. I hope it gets fixed soon though.

Nice catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants