allow notify messages that have 'override: true' - part of BrowserSyn…

…c/browser-sync#538
BrowserSync · Feb 13, 2017 · 6b10879 · 6b10879
1 parent 057f745
commit 6b10879
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/notify.js b/lib/notify.js
@@ -71,7 +71,7 @@ exports.init = function (bs) {
  */
 exports.watchEvent = function (bs) {
     return function (data) {
-        if (bs.options.notify) {
+        if (bs.options.notify || data.override) {
             if (typeof data === "string") {
                 return exports.flash(data);
             }

diff --git a/test/client-new/notify.js b/test/client-new/notify.js
@@ -56,6 +56,22 @@ describe("The Notify Element", function() {
         stub.restore();
     });
 
+    it("does not flash a message if notify:false", function(){
+        var stub = sinon.stub(notify, "flash");
+        var cb   = notify.watchEvent({options: {notify:false}});
+        cb({message: "custom message"});
+        sinon.assert.notCalled(stub);
+        stub.restore();
+    });
+
+    it("DOES flash a message if notify:false but override: true", function(){
+        var stub = sinon.stub(notify, "flash");
+        var cb   = notify.watchEvent({options: {notify:false}});
+        cb({message: "custom message", override: true});
+        sinon.assert.calledWithExactly(stub, "custom message", undefined);
+        stub.restore();
+    });
+
     it("should register an listener on the emitter", function () {
         var spy = sinon.spy(bs.emitter, "on");
         notify.init(bs);