fix: remove document.write (#2019)

* fix: remove document.write * fixes --------- Co-authored-by: Shane Osbourne <sosbourne@duckduckgo.com>
BrowserSync · Feb 27, 2023 · 019f8ea · 019f8ea
1 parent 3b0581e
commit 019f8ea
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 6 deletions.
diff --git a/packages/browser-sync/lib/config.js b/packages/browser-sync/lib/config.js
@@ -10,11 +10,11 @@ module.exports = {
         baseDir: path.join(__dirname, "control-panel")
     },
     templates: {
-        scriptTag: path.join(__dirname, "..", "templates/script-tags.tmpl"),
+        scriptTag: path.join(__dirname, "..", "templates/script-tags.html"),
         scriptTagSimple: path.join(
             __dirname,
             "..",
-            "templates/script-tags-simple.tmpl"
+            "templates/script-tags-simple.html"
         ),
         connector: path.join(__dirname, "..", "templates/connector.tmpl")
     },

diff --git a/...er-sync/templates/script-tags-simple.tmpl → ...er-sync/templates/script-tags-simple.html b/...er-sync/templates/script-tags-simple.tmpl → ...er-sync/templates/script-tags-simple.html
diff --git a/packages/browser-sync/templates/script-tags.html b/packages/browser-sync/templates/script-tags.html
@@ -0,0 +1,16 @@
+<script id="__bs_script__">//<![CDATA[
+  (function() {
+    try {
+      var script = document.createElement('script');
+      if ('%async%') {
+        script.async = true;
+      }
+      script.src = '%script%'.replace("HOST", location.hostname);
+      if (document.body) {
+        document.body.appendChild(script);
+      }
+    } catch (e) {
+      console.error("Browsersync: could not append script tag", e);
+    }
+  })()
+//]]></script>
diff --git a/packages/browser-sync/templates/script-tags.tmpl b/packages/browser-sync/templates/script-tags.tmpl
diff --git a/packages/browser-sync/test/specs/e2e/e2e.options.script.async.js b/packages/browser-sync/test/specs/e2e/e2e.options.script.async.js
@@ -21,7 +21,7 @@ describe("E2E script with/without async attribute", function() {
             }
         };
         browserSync(config, function(err, bs) {
-            assert.notInclude(bs.options.get("snippet"), "async");
+            assert.notInclude(bs.options.get("snippet"), "'async'");
             bs.cleanup();
             done();
         });