Skip to content

Commit

Permalink
fix: (client, rxjs) fix imports to avoid the entire library being bun…
Browse files Browse the repository at this point in the history
…dled
  • Loading branch information
shakyShane committed Apr 29, 2018
1 parent b2361d5 commit b8685bc
Show file tree
Hide file tree
Showing 21 changed files with 39 additions and 32 deletions.
2 changes: 1 addition & 1 deletion client/lib/dom-effects/link-replace.dom-effect.ts
Expand Up @@ -2,7 +2,7 @@ import { map } from "rxjs/operators/map";
import { Inputs } from "../index";
import { filter } from "rxjs/operators/filter";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import * as Log from "../log";
import { pluck } from "rxjs/operators/pluck";
import { Events } from "../dom-effects";
Expand Down
2 changes: 1 addition & 1 deletion client/lib/dom-effects/prop-set.dom-effect.ts
@@ -1,6 +1,6 @@
import { map } from "rxjs/operators/map";
import { tap } from "rxjs/operators/tap";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { Events } from "../dom-effects";
import * as Log from "../log";

Expand Down
2 changes: 1 addition & 1 deletion client/lib/dom-effects/set-scroll.dom-effect.ts
Expand Up @@ -2,7 +2,7 @@ import { Inputs } from "../index";
import { ignoreElements } from "rxjs/operators/ignoreElements";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { tap } from "rxjs/operators/tap";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { Events } from "../dom-effects";

export type SetScrollPayload = { x: number; y: number };
Expand Down
2 changes: 1 addition & 1 deletion client/lib/dom-effects/set-window-name.dom-effect.ts
Expand Up @@ -2,7 +2,7 @@ import { Inputs } from "../index";
import { ignoreElements } from "rxjs/operators/ignoreElements";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { tap } from "rxjs/operators/tap";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { Events } from "../dom-effects";

export function setWindowNameDomEffect(xs: Observable<string>, inputs: Inputs) {
Expand Down
2 changes: 1 addition & 1 deletion client/lib/dom-effects/style-set.dom-effect.ts
@@ -1,7 +1,7 @@
import { map } from "rxjs/operators/map";
import { Events } from "../dom-effects";
import { tap } from "rxjs/operators/tap";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import * as Log from "../log";

export interface StyleSetPayload {
Expand Down
14 changes: 8 additions & 6 deletions client/lib/log.ts
Expand Up @@ -97,12 +97,14 @@ export const logHandler$ = new BehaviorSubject({
* Now remove the element after the given timeout
*/
switchMap(([event, options, element, document]) => {
return timer(event[1] || 2000).do(() => {
element.style.display = "none";
if (element.parentNode) {
document.body.removeChild(element);
}
});
return timer(event[1] || 2000).pipe(
tap(() => {
element.style.display = "none";
if (element.parentNode) {
document.body.removeChild(element);
}
})
);
})
);
}
Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/BrowserLocation.ts
Expand Up @@ -2,7 +2,7 @@ import { Inputs } from "../index";
import { pluck } from "rxjs/operators/pluck";
import { filter } from "rxjs/operators/filter";
import { map } from "rxjs/operators/map";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { browserSetLocation } from "../effects/browser-set-location.effect";

Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/BrowserNotify.ts
@@ -1,5 +1,5 @@
import { map } from "rxjs/operators/map";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import * as Log from "../log";

export interface IncomingPayload {
Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/BrowserReload.ts
@@ -1,6 +1,6 @@
import { Inputs } from "../index";
import { filter } from "rxjs/operators/filter";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { mergeMap } from "rxjs/operators/mergeMap";
import { concat } from "rxjs/observable/concat";
Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/ClickEvent.ts
@@ -1,6 +1,6 @@
import { OutgoingSocketEvents } from "../socket-messages";
import { Inputs } from "../index";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { pluck } from "rxjs/operators/pluck";
import { filter } from "rxjs/operators/filter";
import { map } from "rxjs/operators/map";
Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/Connection.ts
@@ -1,7 +1,7 @@
import { Inputs } from "../index";
import { pluck } from "rxjs/operators/pluck";
import { of } from "rxjs/observable/of";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import * as Log from "../log";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { mergeMap } from "rxjs/operators/mergeMap";
Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/Disconnect.ts
@@ -1,5 +1,5 @@
import { ignoreElements } from "rxjs/operators/ignoreElements";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { tap } from "rxjs/operators/tap";

export function incomingDisconnect(xs: Observable<any>) {
Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/FileReload.ts
Expand Up @@ -4,7 +4,7 @@ import { empty } from "rxjs/observable/empty";
import { isBlacklisted } from "../utils";
import { FileReloadEventPayload } from "../../types/socket";
import { of } from "rxjs/observable/of";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { mergeMap } from "rxjs/operators/mergeMap";
import { fileReload } from "../effects/file-reload.effect";
Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/FormToggleEvent.ts
Expand Up @@ -4,7 +4,7 @@ import { Inputs } from "../index";
import { pluck } from "rxjs/operators/pluck";
import { filter } from "rxjs/operators/filter";
import { map } from "rxjs/operators/map";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { setElementToggleValue } from "../effects/set-element-toggle-value.effect";

Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/KeyupEvent.ts
Expand Up @@ -4,7 +4,7 @@ import { Inputs } from "../index";
import { pluck } from "rxjs/operators/pluck";
import { filter } from "rxjs/operators/filter";
import { map } from "rxjs/operators/map";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { setElementValue } from "../effects/set-element-value.effect";

Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/OptionsSet.ts
@@ -1,5 +1,5 @@
import { map } from "rxjs/operators/map";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { setOptions } from "../effects/set-options.effect";
import { tap } from "rxjs/operators/tap";

Expand Down
2 changes: 1 addition & 1 deletion client/lib/messages/ScrollEvent.ts
Expand Up @@ -3,7 +3,7 @@ import { Inputs } from "../index";
import { pluck } from "rxjs/operators/pluck";
import { filter } from "rxjs/operators/filter";
import { map } from "rxjs/operators/map";
import { Observable } from "rxjs/Rx";
import { Observable } from "rxjs/Observable";
import { withLatestFrom } from "rxjs/operators/withLatestFrom";
import { EffectNames } from "../effects";

Expand Down
2 changes: 1 addition & 1 deletion client/lib/socket.ts
@@ -1,5 +1,5 @@
import socket = require("socket.io-client");
import { Observable } from "rxjs";
import { Observable } from "rxjs/Observable";
import { BehaviorSubject } from "rxjs/BehaviorSubject";
import { of } from "rxjs/observable/of";
import { share } from "rxjs/operators/share";
Expand Down
3 changes: 2 additions & 1 deletion client/lib/utils.ts
Expand Up @@ -3,6 +3,7 @@ import { timer } from "rxjs/observable/timer";
import { of } from "rxjs/observable/of";
import { switchMap } from "rxjs/operators/switchMap";
import { startWith } from "rxjs/operators/startWith";
import { mapTo } from "rxjs/operators/mapTo";

export function each(incoming) {
return [].slice.call(incoming || []);
Expand Down Expand Up @@ -143,7 +144,7 @@ export function isBlacklisted(incoming) {
export function createTimedBooleanSwitch(source$, timeout = 1000) {
return source$.pipe(
switchMap(() => {
return concat(of(false), timer(timeout).mapTo(true));
return concat(of(false), timer(timeout).pipe(mapTo(true)));
}),
startWith(true)
);
Expand Down
19 changes: 11 additions & 8 deletions client/vendor/Reloader.ts
Expand Up @@ -8,6 +8,7 @@ import {getLocation, pathFromUrl, pathsMatch, pickBestMatch, splitUrl, updateSea
import {empty} from "rxjs/observable/empty";
import {Observable} from "rxjs/Observable";
import {merge} from "rxjs/observable/merge";
import {timer} from "rxjs/observable/timer";
import {from} from "rxjs/observable/from";
import {filter} from "rxjs/operators/filter";
import {map} from "rxjs/operators/map";
Expand Down Expand Up @@ -126,10 +127,12 @@ export function reload(document: Document, navigator: Navigator) {
from(IMAGE_STYLES)
.pipe(
mergeMap(({ selector, styleNames }) => {
return from(document.querySelectorAll(`[style*=${selector}]`))
.flatMap((img: HTMLImageElement) => {
return from(document.querySelectorAll(`[style*=${selector}]`)).pipe(
mergeMap((img: HTMLImageElement) => {
return reloadStyleImages(img.style, styleNames, path, expando);
})
)

})
)
);
Expand Down Expand Up @@ -292,8 +295,7 @@ export function reload(document: Document, navigator: Navigator) {
.pipe(
take(1)
, mergeMap(() => {
return Observable
.timer(additionalWaitingTime)
return timer(additionalWaitingTime)
.pipe(
tap(() => {
if (link && !link.parentNode) {
Expand Down Expand Up @@ -329,7 +331,7 @@ export function reload(document: Document, navigator: Navigator) {
link.parentNode.insertBefore(tempLink, link);
}

return Observable.timer(200)
return timer(200)
.pipe(
tap(() => {
if (tempLink.parentNode) { tempLink.parentNode.removeChild(tempLink); }
Expand All @@ -345,13 +347,14 @@ export function reload(document: Document, navigator: Navigator) {
rule.__LiveReload_newHref = href;
})
, mergeMap(() => {
return Observable.timer(200)
.do(() => {
return timer(200).pipe(
tap(() => {
// if another reattachImportedRule call is in progress, abandon this one
if (rule.__LiveReload_newHref !== href) { return; }
parent.insertRule(newRule, index);
return parent.deleteRule(index+1);
});
})
)
})
);
}
Expand Down
1 change: 1 addition & 0 deletions client/webpack.config.js
Expand Up @@ -13,6 +13,7 @@ module.exports = {
path: path.join.apply(null, context.concat("dist")),
filename: 'index.js',
},
devtool: "source-map",
plugins: [
// new webpack.NoEmitOnErrorsPlugin(),
],
Expand Down

0 comments on commit b8685bc

Please sign in to comment.