Replace document.writewith appendChild method
#1931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per issue BrowserSync#1600 Chrome browsers throw a violation warning in the console when `document.write` is used for injecting elements. Using the 'appendChild' method to inject the script tag mitigates the violation. Violation reference: https://developers.google.com/web/updates/2016/08/removing-document-write
|
I really don't see how my changes could have caused this CI build to fail. I'm always striving to have my apps not output a single error or warning to console and the document.write makes it feel like I didn't achieve that, which can get pretty annoying. |
|
@shakyShane I think you can close this now. (#2019) |
|
@DysphoricUnicorn thanks for the original PR - the CI tests failed because in some scenarios Browsersync outputs the snippet to the terminal and I had a test that verifies it's correct :) All fixed now in the latest version though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated PR for #1736 that replaces the usage of let with var.
I did this since the usage of let was criticized in a review on the original PR almost a year ago with no update since.