Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ie11 #2024

Merged
merged 1 commit into from Mar 16, 2023
Merged

fix ie11 #2024

merged 1 commit into from Mar 16, 2023

Conversation

shakyShane
Copy link
Contributor

No description provided.

@shakyShane shakyShane merged commit 87421b5 into master Mar 16, 2023
2 checks passed
renovate bot added a commit to openedx/edx-ui-toolkit that referenced this pull request Mar 20, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [browser-sync](https://browsersync.io/)
([source](https://togithub.com/BrowserSync/browser-sync)) | [`2.28.3` ->
`2.29.0`](https://renovatebot.com/diffs/npm/browser-sync/2.28.3/2.29.0)
|
[![age](https://badges.renovateapi.com/packages/npm/browser-sync/2.29.0/age-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://badges.renovateapi.com/packages/npm/browser-sync/2.29.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://badges.renovateapi.com/packages/npm/browser-sync/2.29.0/compatibility-slim/2.28.3)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://badges.renovateapi.com/packages/npm/browser-sync/2.29.0/confidence-slim/2.28.3)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>BrowserSync/browser-sync</summary>

###
[`v2.29.0`](https://togithub.com/BrowserSync/browser-sync/releases/tag/v2.29.0):
The one that restores IE11 support 💪

[Compare
Source](https://togithub.com/BrowserSync/browser-sync/compare/v2.28.3...v2.29.0)

#### What's Changed

- fix ie11 by [@&#8203;shakyShane](https://togithub.com/shakyShane) in
[BrowserSync/browser-sync#2024

[esbuild](https://esbuild.github.io/) does not support down-level
transpiling as far as IE11 - so when I switched to it, it accidentally
broke `IE11` support 😢

This is an important issue for me - many devs that support old browsers
like IE11 are doing so because their projects are used in public
services, or internal applications. Not every developer out there has
the luxury of supporting evergreen-only browsers.

So, IE11 will work once again 🎉. Please use the
[issues](https://togithub.com/BrowserSync/browser-sync/issues) thread to
make me aware of any problem that's preventing you from using
Browsersync in your day job 💪 (and be sure to thumbs-up the issues you
want to see resolved)

```shell

### IE11 works, again
npm install browser-sync@latest
```

**Full Changelog**:
BrowserSync/browser-sync@v2.28.3...v2.29.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on Monday" in timezone
America/New_York, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/openedx/edx-ui-toolkit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNC4wIiwidXBkYXRlZEluVmVyIjoiMzUuMTQuMCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Kristinita
Copy link

Type: Opinion 💬

In my opinion, for developers should be preferable to support users who use new browsers than users who use older browsers. I don’t think spending time supporting Internet Explorer, which is used by 0.42% of users, while there are 535 issues and 25 pull requests open is the best idea.

Moreover, when Internet Explorer was actively developed, it was the worst browser for web developers, its support took a lot of time. Now, in 2024, forcing people to use Internet Explorer seems like bosses sadism or reluctance to update very outdated services/applications.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants