Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for user groups adding users to app user metadata tables #10120

Merged
merged 19 commits into from Mar 28, 2023

Conversation

mike12345567
Copy link
Collaborator

@mike12345567 mike12345567 commented Mar 27, 2023

Description

There was an issue that caused user's added to groups to be added to all app user metadata tables - this includes a small fix for it.

The majority of the work in this PR was around testing, there has been issues with the server testing before now, I've updated Jest and I believe this should resolve the issue we've been seeing where the server tests haven't been running correctly/haven't been showing coverage. Updating jest also broke a few test cases (namely snapshot tests) which required updates.

Also ran into some issues with Node 16.10+ versions, it seems that we have introduced an issue with the switch to swc - I spent a lot of time looking into this, our tests were leaking memory, but it turns out this is a known issue with Node 16.10+ and Jest + SWC. jestjs/jest#7874 (comment)

There are also some other various fixes/improvements due to the way Jest expect changed a bit.

NOTE: most of the LoC changed here are from the yarn.lock being massively updated due to all the Jest library updates.

Addresses:

@mike12345567 mike12345567 self-assigned this Mar 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2023

Codecov Report

Merging #10120 (502a8b1) into develop (ce86edf) will increase coverage by 18.46%.
The diff coverage is 63.51%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##           develop   #10120       +/-   ##
============================================
+ Coverage    50.23%   68.70%   +18.46%     
============================================
  Files          222      511      +289     
  Lines         6109    19196    +13087     
  Branches       988     3889     +2901     
============================================
+ Hits          3069    13188    +10119     
- Misses        2169     5550     +3381     
+ Partials       871      458      -413     
Impacted Files Coverage Δ
packages/backend-core/src/index.ts 0.00% <ø> (ø)
packages/worker/src/index.ts 62.85% <0.00%> (+4.88%) ⬆️
packages/worker/src/tests/TestConfiguration.ts 89.68% <0.00%> (+3.68%) ⬆️
packages/backend-core/src/queue/queue.ts 22.85% <25.00%> (-0.48%) ⬇️
packages/backend-core/src/timers/timers.ts 28.57% <28.57%> (ø)
packages/backend-core/src/redis/redis.ts 56.32% <33.33%> (+7.06%) ⬆️
packages/server/src/utilities/global.ts 77.21% <46.15%> (ø)
packages/server/src/app.ts 54.28% <50.00%> (ø)
...es/server/src/tests/utilities/TestConfiguration.ts 92.26% <85.71%> (ø)
packages/backend-core/src/timers/index.ts 100.00% <100.00%> (ø)
... and 7 more

... and 432 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mike12345567 mike12345567 merged commit 5f63f7a into develop Mar 28, 2023
6 checks passed
@mike12345567 mike12345567 deleted the fix/budi-6657 branch March 28, 2023 00:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants