Synced ComponentInfo to the current state of Component interface in gen1 builder.class.ts #2886
Conversation
…en1 builder.class.ts
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
| export { isBrowser } from './functions/is-browser.js'; | ||
| export { isServer } from './functions/is-server.js'; |
There was a problem hiding this comment.
I don't think we want to export these in the new SDKs. It makes little sense to provide our users with helpers like these: they have nothing to do with SDK functionality.
What is the use case for adding them here?
There was a problem hiding this comment.
We have exposed these helpers before in Gen1 and they are widely used in client code, example - in our site. Migrating to gen2 will require users with a substitute, thus exporting them
There was a problem hiding this comment.
I understand, and that's the way to go. I would rather users rely on their own isBrowser/isServer helpers than reuse ours. The Builder SDK shouldn't be exporting generic helpers such as these: they are unrelated to the Builder SDK's purpose.
| class?: any; | ||
| /** @hidden @deprecated */ |
There was a problem hiding this comment.
Thanks for adding these tags. We will want to go ahead and completely remove any deprecated attributes in gen2 SDKs before we bump to v1, as this is our big chance to remove deprecated features.
They can stay here for now though, and these tags will help us know what to remove in the near future 👍🏽
Description
Synced missing fields in gen2's
ComponentInfointerface with gen1'sComponentinterface inbuilder.class.ts