Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow lossless integer to float conversions #325

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Allow lossless integer to float conversions #325

merged 2 commits into from
Nov 16, 2021

Commits on Nov 16, 2021

  1. Allow lossless integer to float conversions 

    According to the specification, 64-bit signed integers should be
accepted providing they can be represented losslessly.

At the moment, integers to be converted to a float immediately return an
error. This change permits integers and only returns an error if they
would overflow the float type they're being converted to as they have no
problem being represented losslessly.

In addition, this change returns an error if a float is provided but
cannot fit within the float type specified by the struct.
    @saracen @arp242
    saracen authored and arp242 committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    96912c0 View commit details
    Browse the repository at this point in the history

  2. A few minor stylistic changes

    @arp242
    arp242 committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    79893e4 View commit details
    Browse the repository at this point in the history