Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better transport argument sanitization #1032

Merged
merged 3 commits into from Sep 24, 2023
Merged

better transport argument sanitization #1032

merged 3 commits into from Sep 24, 2023

Commits on Sep 24, 2023

  1. feat: add Url::host_argument_safe() and Url::path_argument_safe() 

    This will not provide values if they could be confused for an argument
to to a commaneline application.
    @Byron
    Byron committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    d80b5f6 View commit details
    Browse the repository at this point in the history

  2. fix: prevent hosts or paths that look like arguments to be passed to … 

    …invoked commands.

See https://secure.phabricator.com/T12961 for more details.
    @Byron
    Byron committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    b06a0dd View commit details
    Browse the repository at this point in the history

  3. improve journey test to validate handling ambiguous of ssh-hosts

    @Byron
    Byron committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    114e91c View commit details
    Browse the repository at this point in the history