Improve wasi support for gix-config #1347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
reviewed
Apr 19, 2024
| with: | ||
| toolchain: nightly | ||
| targets: wasm32-wasi | ||
| - name: "check" |
There was a problem hiding this comment.
Would it be possible to integrate this check with the one that exists?
Probably gix-fs and gix-sec should also be tested explicitly then.
There was a problem hiding this comment.
gix-fs and gix-sec are added with --all-features flag
There was a problem hiding this comment.
Have you seen the other check? Is there any chance this one here can be integrated into the other one?
|
Have you seen this comment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gix-configis used by https://github.com/nrwl/nx, I'm trying to help nx to compile withwasm32-wasip1-threadstarget so that it can be used on the StackBlitz.This pull request is improving the
gix-configwasi compatibility, and also introduces a CI to check thegix-configwithwasm32-wasitarget.