Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): link using "system" ABI #93

Merged
merged 1 commit into from Mar 7, 2024

Conversation

amrbashir
Copy link
Contributor

@amrbashir amrbashir commented Mar 7, 2024

Finally was able to reproduce #91 (comment)
through tauri-apps/plugins-workspace#1046

This was a mistake on my part in #91, I didn't notice that I used the wrong ABI, funnily enough I can still build on x86 & x64 targets using the wrong ABI.

@amrbashir amrbashir changed the title Fix/shell-execute-w-link fix(windows): link using "system" ABI Mar 7, 2024
@Byron Byron merged commit 50b7a96 into Byron:main Mar 7, 2024
7 checks passed
@Byron
Copy link
Owner

Byron commented Mar 7, 2024

Thanks a lot, I am glad the 'riddle' could be solved after all.

A new release is here: https://github.com/Byron/open-rs/releases/tag/v5.1.2 .

@amrbashir
Copy link
Contributor Author

Thank you, appreciate the quick release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants