Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image fitting with beam deconvolved images #1236

Open
YuHsuan-Hwang opened this issue Feb 3, 2023 · 3 comments
Open

Image fitting with beam deconvolved images #1236

YuHsuan-Hwang opened this issue Feb 3, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@YuHsuan-Hwang
Copy link
Contributor

Support image fitting with beam deconvolved images.

Requirement document:
https://docs.google.com/document/d/1E9kL7FOhVtkDDit8VIYle61tU5PzSYXjnLpxZBCHliY/edit?usp=sharing

@markccchiang
Copy link
Contributor

markccchiang commented Jan 9, 2024

Checking with the original fit function in the CASA imfit. It seems the deconvolved fit results are calculated from the fit results from the raw image pixel data (see ImageFitter.tcc from the CASA code). So we don't need to generate a beam-deconvolved image and do another fit.

@kswang1029
Copy link
Contributor

kswang1029 commented Jan 9, 2024

Checking with the original fit function in the CASA imfit. It seems the deconvolved fit results are calculated from the fit results from the raw image pixel data (see ImageFitter.tcc from the CASA code). So we don't need to generate a beam-deconvolved image and do another fit.

could you provide an outline a bit on how it works?

@markccchiang
Copy link
Contributor

Checking with the original fit function in the CASA imfit. It seems the deconvolved fit results are calculated from the fit results from the raw image pixel data (see ImageFitter.tcc from the CASA code). So we don't need to generate a beam-deconvolved image and do another fit.

could you provide an outline a bit on how it works?

This code is a little bit complicated for me. Basically, it is done in the _setDeconvolvedSizes() method from ImageFitter.tcc. It takes the image beam information and uses the casa::GaussianDeconvolver::deconvolve method to do the deconvolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Backlog
Status: Backlog
Development

No branches or pull requests

3 participants