Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate fitting results for beam deconvolved images #1364

Closed
wants to merge 50 commits into from

Conversation

markccchiang
Copy link
Contributor

@markccchiang markccchiang commented Mar 19, 2024

Description

  • What is implemented or fixed? Mention the linked issue(s), if any.
    Implement Image fitting with beam deconvolved images #1236.

  • How does this PR solve the issue? Give a brief summary.
    Create a class Deconvolver which converts the fitting results to beam deconvolved images. The convolution method is originally from the casacode.

  • Are there any companion PRs (frontend, protobuf)?
    So far no. Question: do we need to create an image for fitting results with beam deconvolution? If so, we may need to modify the frontend and protobuf. We can choose to show both fitting PDF images w and w/o beam deconvolution or there is an option to show only one of them.

  • Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
    When fitting with the image that has beam information, the fitting results with beam deconvolution will also shown like the following snapshot:

截圖 2024-04-16 下午3 56 30

Checklist

  • changelog updated / no changelog update needed
  • e2e test passing / corresponding fix added / new e2e test created
  • ICD test passing / corresponding fix added / new ICD test created
  • protobuf updated to the latest dev commit / no protobuf update needed
  • protobuf version bumped / protobuf version not bumped
  • added reviewers and assignee
  • added ZenHub estimate, milestone, and release

@markccchiang markccchiang added the blocked Development done but blocked by another issue label Apr 8, 2024
@markccchiang markccchiang added the requiring frontend this backend issue requires work in both frontend and backend label Apr 8, 2024
Copy link

Code Coverage

Package Line Rate Health
src.Cache 72%
src.DataStream 44%
src.FileList 67%
src.Frame 36%
src.HttpServer 42%
src.ImageData 28%
src.ImageFitter 76%
src.ImageGenerators 43%
src.ImageStats 75%
src.Logger 37%
src.Main 52%
src.Region 69%
src.Session 4%
src.Table 52%
src.ThreadingManager 67%
src.Timer 85%
src.Util 40%
Summary 46% (8874 / 19168)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Development done but blocked by another issue requiring frontend this backend issue requires work in both frontend and backend
Projects
No open projects
Status: New issues/PRs
Development

Successfully merging this pull request may close these issues.

None yet

1 participant