Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect trimmed velocity header of ATCA FITS images #1375

Closed
TienHao opened this issue May 10, 2024 · 0 comments · Fixed by #1376
Closed

incorrect trimmed velocity header of ATCA FITS images #1375

TienHao opened this issue May 10, 2024 · 0 comments · Fixed by #1376
Assignees

Comments

@TienHao
Copy link

TienHao commented May 10, 2024

Describe the bug
This is related to CARTAvis/carta-frontend#2357.
The frontend receives incorrect headers of velocity(CTYPE3) from ATCA FITS images.
The original value of CTYPE3 in the FITS headers is 'VELO-XXX' (eg. VELO-HEL, VELO-LSR), but the OpenFileAck message shows 'VELO' in that key..

VELO-HEL turns to VELO
截圖 2024-05-02 下午2 38 03
截圖 2024-05-02 下午2 48 59

VELO-LSR turns to VELO
截圖 2024-05-02 下午3 09 36
截圖 2024-05-02 下午2 58 14

To Reproduce

  1. download the test images here:
    https://drive.google.com/file/d/1MrseMvR3j9YVeLk_4bwCmDjvIaPHUtye/view?usp=sharing (CTYPE3 = 'VELO-HEL')
    https://drive.google.com/file/d/1ynmyPlgEJolb_1D8m5tWNapXIGMwmUHO/view?usp=sharing (CTYPE3 = 'VELO-LSR')

  2. load it and check the log of OpenFileAck(or File header), and we will see the incorrect header.

Expected behavior
The CTYPE3 in the OpenFileAck message should be the same as the one in the FITS header.

Screenshots or videos
If applicable, add screenshots/videos to help explain your problem.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Sonoma
  • Browser [e.g. chrome, safari, electron app]: Chrome
  • Browser version [e.g. 22]: 124
  • Backend branch [e.g. dev, v3b2 release]: dev
  • Frontend branch [e.g. dev, v3b2 release]: dev

Additional context
Add any other context about the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants