Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parsing ATCA FITS header - no WCS grid rendered #2357

Closed
kswang1029 opened this issue Mar 7, 2024 · 2 comments
Closed

parsing ATCA FITS header - no WCS grid rendered #2357

kswang1029 opened this issue Mar 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kswang1029
Copy link
Collaborator

kswang1029 commented Mar 7, 2024

Describe the bug

With v4.1-stable, some of the ATCA FITS images cannot have WCS grid rendered properly (missing) at the frontend.

The attached image shows the headers as displayed in v3 (left) and v4.1 (right) respectively.
Screenshot 2024-03-07 at 15 39 46

The key difference is CTYPE3
v3
CTYPE3 = VELO-HEL
BUNIT = JY/BEAM
v4.1
CTYPE3 = VELO
BUNIT = Jy/beam

With ds9 we see
CTYPE3 = 'VELO-HEL'
BUNIT = 'JY/BEAM '

With some other ATCA FITS images, it works just fine (ex https://drive.google.com/file/d/1ynmyPlgEJolb_1D8m5tWNapXIGMwmUHO/view?usp=sharing)

To Reproduce
Steps to reproduce the behavior:

  1. download the test image here: https://drive.google.com/file/d/1MrseMvR3j9YVeLk_4bwCmDjvIaPHUtye/view?usp=sharing
  2. load it and we will see missing WCS grid.
  3. try to generate a moment image but we will see errors in the browser's console.
Screenshot 2024-03-07 at 15 50 40

Expected behavior
WCS grid should be rendered and moment image can be generated.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Ventura
  • Browser [e.g. chrome, safari, electron app]: v4.1 electron app
  • Browser version [e.g. 22]:
  • Backend branch [e.g. dev, v3b2 release]: v4.1, dev
  • Frontend branch [e.g. dev, v3b2 release]: v4.1 dev
@kswang1029 kswang1029 added the bug Something isn't working label Mar 7, 2024
@kswang1029 kswang1029 added this to the v5.0-beta milestone Mar 7, 2024
@kswang1029 kswang1029 transferred this issue from CARTAvis/carta-backend Mar 8, 2024
@TienHao
Copy link
Contributor

TienHao commented May 2, 2024

I found both ATCA images are inconsistent between the OpenFileAck and the fits files headers in CTYPE3. There might be a change of file info parsing from the backend causing this problem.

For the WCS rendering failed ATCA image(link):
The headerEntries of OpenFileAck from the backend shows CTYPE3 = 'VELO'.
But the header from the fits file shows CTYPE3 = 'VELO-HEL'
截圖 2024-05-02 下午2 48 59
截圖 2024-05-02 下午2 38 03

For the WCS rendering succeeded one(link):
The headerEntries of OpenFileAck from the backend shows CTYPE3 = 'VELO' just like the failed one.
But the header from the fits file shows CTYPE3 = 'VELO-LSR'
截圖 2024-05-02 下午2 58 14
截圖 2024-05-02 下午3 09 36

I am not sure why it works fine for the second image, but the missing of chars is spotted.

@kswang1029
Copy link
Collaborator Author

kswang1029 commented Jun 3, 2024

Refer to CARTAvis/carta-backend#1375 for the issue.
This is going to be fixed via CARTAvis/carta-backend#1376.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: New issues/PRs
Status: New issues/PRs
Development

No branches or pull requests

2 participants