-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom prefix to all HTTP server URLs #1338
base: dev
Are you sure you want to change the base?
Conversation
…level string processing with regexes. Revise normalization logic. Add the prefix to the api address reported to the frontend.
@appolloford and @Micket, does this solution still work for you with the prefix set using a configuration option rather than an environment variable? This option can be passed on the commandline ( |
Having a configuration option in commandline should work well, but I am wondering whether the priority is higher than users' config file. We need the node name and port number information in the URL prefix so that we can have OnDemand find the computing node. There may be some trouble if users overwrite it with some arbitrary value. |
@appolloford yes, the commandline parameters have the highest priority, and override the user config file, which overrides the global config file. You can also use commandline parameters to disable the user and/or global config file entirely. |
@confluence do we consider the following use cases?
If I do so, I see errors as
The core question is how do we support the scripting interface when the |
@kswang1029 that's a wrapper issue which should be discussed here. I thought that the wrapper didn't require changes, but I hadn't fully tested it yet. |
@kswang1029 actually, this is an issue with |
|
@kswang1029 I have pushed a change which I think fixes this issue. With this fix, I believe that your use case should work with the current development wrapper. Additionally, wrapper PR #154 fixes a parsing issue which breaks starting a backend from the wrapper with a prefix and auth. |
Description
This is a re-creation of #1307 with a copy of the branch in our main repo, and implements #1309.
To be done before this can move out of draft:
Checklist
protobuf updated to the latest dev commit/ no protobuf update neededprotobuf version bumped/ protobuf version not bumped