Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support channel map for range of channels #1356

Draft
wants to merge 11 commits into
base: dev
Choose a base branch
from
Draft

Conversation

pford
Copy link
Collaborator

@pford pford commented Jan 30, 2024

Description
Draft PR pending frontend support for testing.

  • What is implemented or fixed? Mention the linked issue(s), if any.
    Implements channel map view (backend) #1186
  • How does this PR solve the issue? Give a brief summary.
    Using the channel_range added to SetImageChannels message, backend sends the requested tiles for the requested channels. The downsampled data for each channel is retrieved to create the tiles but is not stored. (TODO: check tile cache)
  • Are there any companion PRs (frontend, protobuf)?
    channel map view (frontend) carta-frontend#1203 (issue), Add channel range field for channel map carta-protobuf#92
  • Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?
    Select channel map view, should be shown a grid of images with consecutive channels.

Checklist

  • changelog updated / no changelog update needed
  • e2e test passing / corresponding fix added / new e2e test created
  • ICD test passing / corresponding fix added / new ICD test created
  • protobuf updated to the latest dev commit / no protobuf update needed
  • protobuf version bumped / protobuf version not bumped
  • added reviewers and assignee
  • added ZenHub estimate, milestone, and release

@pford pford added the requiring frontend this backend issue requires work in both frontend and backend label Jan 30, 2024
@pford pford added this to the v5.0-beta milestone Jan 30, 2024
@pford pford linked an issue Jan 30, 2024 that may be closed by this pull request
@pford pford added the blocked Development done but blocked by another issue label Jan 30, 2024
Copy link

Code Coverage

Package Line Rate Health
src.Cache 72%
src.DataStream 44%
src.FileList 67%
src.Frame 36%
src.HttpServer 42%
src.ImageData 28%
src.ImageFitter 83%
src.ImageGenerators 43%
src.ImageStats 75%
src.Logger 37%
src.Main 52%
src.Region 69%
src.Session 4%
src.Table 52%
src.ThreadingManager 67%
src.Timer 85%
src.Util 40%
Summary 46% (8614 / 18831)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Development done but blocked by another issue requiring frontend this backend issue requires work in both frontend and backend requiring protobuf
Projects
No open projects
Status: New issues/PRs
Development

Successfully merging this pull request may close these issues.

channel map view (backend)
1 participant