Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save profile data on the server side #1360

Closed
wants to merge 10 commits into from

Conversation

markccchiang
Copy link
Contributor

Description

  • What is implemented or fixed? Mention the linked issue(s), if any.
    Implement [data interfacing] save profile data at the server-side (backend) #1342.

  • How does this PR solve the issue? Give a brief summary.
    Create a class DataExporter to handle the export of profile data on the server side. The frontend sends CARTA::EventType::EXPORT_DATA with CARTA::ExportData message to the backend. The backend replies CARTA::EventType::EXPORT_DATA_ACK with CARTA::ExportDataAck message to indicate whether the data export is successful or not. Note that the profile data file can not be saved on the directory that does not exist.

  • Are there any companion PRs (frontend, protobuf)?
    It requires changes in the frontend and protobuf (temporary branch: mark/save_profile_data).

  • Is there anything else that testers should know (e.g. exactly how to reproduce the issue)?

Checklist

  • changelog updated / no changelog update needed
  • e2e test passing / corresponding fix added / new e2e test created
  • ICD test passing / corresponding fix added / new ICD test created
  • protobuf updated to the latest dev commit / no protobuf update needed
  • protobuf version bumped / protobuf version not bumped
  • added reviewers and assignee
  • added ZenHub estimate, milestone, and release

@markccchiang markccchiang added blocked Development done but blocked by another issue requiring frontend this backend issue requires work in both frontend and backend labels Feb 20, 2024
Copy link

Code Coverage

Package Line Rate Health
src.Cache 72%
src.DataStream 44%
src.FileList 67%
src.Frame 36%
src.HttpServer 42%
src.ImageData 28%
src.ImageFitter 83%
src.ImageGenerators 43%
src.ImageStats 75%
src.Logger 37%
src.Main 52%
src.Region 69%
src.Session 4%
src.Table 52%
src.ThreadingManager 67%
src.Timer 85%
src.Util 41%
Summary 46% (8642 / 18841)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Development done but blocked by another issue requiring frontend this backend issue requires work in both frontend and backend
Projects
No open projects
Status: New issues/PRs
Development

Successfully merging this pull request may close these issues.

None yet

1 participant