Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blueprintjs v4 upgrade #1395

Closed
kswang1029 opened this issue Apr 10, 2021 · 4 comments · Fixed by #1975
Closed

Blueprintjs v4 upgrade #1395

kswang1029 opened this issue Apr 10, 2021 · 4 comments · Fixed by #1975
Assignees
Labels
code maintenance For issues relating to code maintenance and quality
Milestone

Comments

@kswang1029
Copy link
Collaborator

https://github.com/palantir/blueprint/wiki/Blueprint-4.0

aiming carta >= v3.0

@veggiesaurus
Copy link
Collaborator

that was fast for a Saturday evening, @kswang1029 😆

@veggiesaurus veggiesaurus added the code maintenance For issues relating to code maintenance and quality label Apr 14, 2021
@kswang1029
Copy link
Collaborator Author

need to monitor the v4 release schedule then we can get this issue scheduled in our development cycle.

@kswang1029 kswang1029 modified the milestones: v3.0b-1, v3.0b-2 Jul 12, 2021
@veggiesaurus veggiesaurus removed this from the v3.0b-2 milestone Aug 24, 2021
@kswang1029
Copy link
Collaborator Author

@veggiesaurus @YuHsuan-Hwang just found that v4 has been released (finally).

@veggiesaurus veggiesaurus self-assigned this Aug 15, 2022
@veggiesaurus veggiesaurus added this to the v4.0-b1 milestone Aug 15, 2022
This was referenced Aug 15, 2022
@veggiesaurus veggiesaurus assigned TienHao and unassigned veggiesaurus Sep 14, 2022
@kswang1029 kswang1029 removed this from the v4.0-b1 milestone May 8, 2023
@kswang1029 kswang1029 added this to the v5.0-beta milestone Oct 3, 2023
@veggiesaurus
Copy link
Collaborator

Blueprint 5 is now out and stable. It's a minor update on BP4. Having recently gone through a similar upgrade, some things I've learnt:

We can make our lives much easier by doing prep work before the actual upgrade:

  • use proper class names in typescript from the Classes import
  • use the ns variable in SCSS instead of bp3 or bp4 prefixes
  • Start moving away from deprecated components and use their replacement components instead. Some are for example popover, tooltip, menuitem and overlay

Once we've made these changes we can proceed with the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code maintenance For issues relating to code maintenance and quality
Projects
No open projects
Status: PR test and review
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants