-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial blueprint4 upgrade #1975
Conversation
Assigning this to @kswang1029, as it is primarily a user-facing thing. Most of the upgrades were fairly straightforward. I've removed deprecated code where possible. |
@veggiesaurus not sure why but I am seeing e2e test failures due to changes of xpath (eg. the file filter text field). I will need more time to investigate this. And you are right about the color theme: the contrast is increased and the color theme appears less warm. |
in the file browser, the sorting function in the the Filename, Type, Size, and Date columns does not work anymore. |
@veggiesaurus @YuHsuan-Hwang there are a number of issues due to this library upgrade. I will summarize them in a google doc, just for better readability than posting here as a comment thread. |
@veggiesaurus please refer to https://docs.google.com/document/d/1UgbYN7CzW2ziPeYo7bn_vDxHrSgs1ri6QDjXS86ylYk/edit?usp=sharing for a list of issues I observed with this blueprintjsV4 upgrade. Basically there are major issues with
|
- the misplaced lock icon in Contour dialogue - Table2 rerender issues in Cursor Info and hypercube dialogue
@TienHao most of the issues in https://docs.google.com/document/d/1UgbYN7CzW2ziPeYo7bn_vDxHrSgs1ri6QDjXS86ylYk/edit are addressed. 👍 |
* refactoring code with ref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @TienHao 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes look good.
Description
Closes #1395. It may also close a number of table-related issues.
Requires a fair amount of testing, and will likely break e2e tests.
Checklist
For linked issues (if there are):
For the pull request:
no changelog update neededunit test added (for functions with no dependencies)API documentation added (for public variables and methods in stores)For dependencies:
e2e test passing/ corresponding fix added /new e2e test createdprotobuf version bumped/ no protobuf version bumped neededprotobuf updated to the latest dev commit/ no protobuf update neededcorresponding ICD test fix added (/ no ICD test fix needed (BackendService
changed)BackendService
unchanged)user manual prepared (for large new features)