Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial blueprint4 upgrade #1975

Merged
merged 65 commits into from
May 17, 2024
Merged

initial blueprint4 upgrade #1975

merged 65 commits into from
May 17, 2024

Conversation

veggiesaurus
Copy link
Collaborator

@veggiesaurus veggiesaurus commented Aug 15, 2022

Description
Closes #1395. It may also close a number of table-related issues.
Requires a fair amount of testing, and will likely break e2e tests.

Checklist

For linked issues (if there are):

  • assignee and label added
  • ZenHub issue connection, board status, and estimate updated

For the pull request:

  • reviewers and assignee added
  • ZenHub estimate, milestone, and release (if needed) added
  • changelog updated / no changelog update needed
  • unit test added (for functions with no dependencies)
  • API documentation added (for public variables and methods in stores)

For dependencies:

  • e2e test passing / corresponding fix added / new e2e test created
  • protobuf version bumped / no protobuf version bumped needed
  • protobuf updated to the latest dev commit / no protobuf update needed
  • corresponding ICD test fix added (BackendService changed) / no ICD test fix needed (BackendService unchanged)
  • user manual prepared (for large new features)

@veggiesaurus
Copy link
Collaborator Author

Assigning this to @kswang1029, as it is primarily a user-facing thing. Most of the upgrades were fairly straightforward. I've removed deprecated code where possible.

@veggiesaurus veggiesaurus marked this pull request as ready for review August 22, 2022 07:24
@kswang1029
Copy link
Collaborator

@veggiesaurus not sure why but I am seeing e2e test failures due to changes of xpath (eg. the file filter text field). I will need more time to investigate this. And you are right about the color theme: the contrast is increased and the color theme appears less warm.

@kswang1029
Copy link
Collaborator

One issue: the initial file browser highlight box is squeezed.
with this PR
Screen Shot 2022-09-01 at 20 56 31
current dev
Screen Shot 2022-09-01 at 20 56 54

@kswang1029
Copy link
Collaborator

in the file browser, the sorting function in the the Filename, Type, Size, and Date columns does not work anymore.

@kswang1029
Copy link
Collaborator

@veggiesaurus @YuHsuan-Hwang there are a number of issues due to this library upgrade. I will summarize them in a google doc, just for better readability than posting here as a comment thread.

@kswang1029
Copy link
Collaborator

@veggiesaurus please refer to https://docs.google.com/document/d/1UgbYN7CzW2ziPeYo7bn_vDxHrSgs1ri6QDjXS86ylYk/edit?usp=sharing for a list of issues I observed with this blueprintjsV4 upgrade. Basically there are major issues with

  • spinbox
  • html table
  • blueprint table 🤦🏻‍♂️

@YuHsuan-Hwang YuHsuan-Hwang marked this pull request as draft November 22, 2022 06:43
- the misplaced lock icon in Contour dialogue

- Table2 rerender issues in Cursor Info and hypercube dialogue
@TienHao TienHao marked this pull request as ready for review March 23, 2023 05:53
@kswang1029
Copy link
Collaborator

@TienHao most of the issues in https://docs.google.com/document/d/1UgbYN7CzW2ziPeYo7bn_vDxHrSgs1ri6QDjXS86ylYk/edit are addressed. 👍
there are some new others. Please refer to the above doc.

@YuHsuan-Hwang YuHsuan-Hwang mentioned this pull request Mar 19, 2024
12 tasks
@YuHsuan-Hwang YuHsuan-Hwang added the blocked For issues that are blocked, either by other issues, or by external dependencies label Apr 3, 2024
@YuHsuan-Hwang YuHsuan-Hwang removed the blocked For issues that are blocked, either by other issues, or by external dependencies label May 8, 2024
Copy link
Collaborator

@kswang1029 kswang1029 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @TienHao 👍

@kswang1029 kswang1029 added awaiting merge For pull requests ready for merge or pending backend/protobuf changes and removed awaiting code review For pull requests that require code review awaiting testing For pull requests that require testing labels May 15, 2024
@YuHsuan-Hwang YuHsuan-Hwang self-requested a review May 15, 2024 05:34
@kswang1029 kswang1029 added awaiting code review For pull requests that require code review awaiting testing For pull requests that require testing and removed awaiting merge For pull requests ready for merge or pending backend/protobuf changes labels May 15, 2024
@kswang1029 kswang1029 self-requested a review May 15, 2024 05:35
Copy link
Collaborator

@YuHsuan-Hwang YuHsuan-Hwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New changes look good.

@YuHsuan-Hwang YuHsuan-Hwang removed the awaiting code review For pull requests that require code review label May 16, 2024
@kswang1029 kswang1029 merged commit 6065ac9 into dev May 17, 2024
6 checks passed
@kswang1029 kswang1029 deleted the angus/1395_blueprint4 branch May 17, 2024 06:32
@YuHsuan-Hwang YuHsuan-Hwang removed the awaiting testing For pull requests that require testing label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: PR test and review
Development

Successfully merging this pull request may close these issues.

Blueprintjs v4 upgrade
4 participants