thchang/ issue 1786 QU profile #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswang1029
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
all e2e tests are passing. Manual test looks good. 👍
@YuHsuan-Hwang if you think this is low risk, we can consider to get this into v3-stable.
YuHsuan-Hwang
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #1786: Q,U rendering black at first channel in the stokes widget.
Fixed this issue by removing the workaround, adding empty color string in
fillLineColor, which is no longer needed for the bug has been fixed after Chart.js v3.6.0.Checklist
added corresponding fixprotobuf updated to the latest dev commit/ no protobuf update needed