Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angus/remote file requests #2346

Open
wants to merge 30 commits into
base: dev
Choose a base branch
from
Open

Conversation

veggiesaurus
Copy link
Collaborator

@veggiesaurus veggiesaurus commented Feb 12, 2024

Description

WIP for loading images from hips2fits server

Checklist

For linked issues (if there are):

  • assignee and label added
  • ZenHub issue connection, board status, and estimate updated

For the pull request:

  • reviewers and assignee added
  • ZenHub estimate, milestone, and release (if needed) added
  • changelog updated / no changelog update needed
  • unit test added (for functions with no dependenies)
  • API documentation added (for public variables and methods in stores)

For dependencies:

  • e2e test passing / corresponding fix added / new e2e test created
  • protobuf version bumped / no protobuf version bumped needed
  • protobuf updated to the latest dev commit / no protobuf update needed
  • corresponding ICD test fix added (BackendService changed) / no ICD test fix needed (BackendService unchanged)
  • user manual prepared (for large new features)

@YuHsuan-Hwang
Copy link
Collaborator

Ready for review.

Changes:

  • Changed the "Online catalog query" dialog to "Online data query" dialog, and added two tabs for catalog queries and HiPS survey queries.
  • Enabled the dialog button and the menu option when there is no image loaded.
  • Added HiPS survey query UI. Users can query by either the object name or the center coordinates.
  • Pinned the action buttons at the button of the dialog. The "Query" button is disabled if any of the input is not valid or a query is in progress. The "Clear" button resets the inputs.
  • When a query is sent, a spinner is shown and all UI is disabled.
  • Added documentation and unit tests for HipsQueryStore.

This PR is currently for the basic features of HiPS data queries. There are some possible enhancements, and I would suggest we file a new issue for them:

  • For the HiPS survey text input, search for available surveys and show them in a dropdown.
  • For center coordinates and fov, add shortcut buttons to set by the parameters of an active image (similar UI in the online catalog query widget).
  • Add cancel button for the query (is this possible?).
  • (optional) Adjust the catalog query UI for consistency.

@YuHsuan-Hwang YuHsuan-Hwang marked this pull request as ready for review May 24, 2024 07:44
@YuHsuan-Hwang YuHsuan-Hwang added awaiting code review For pull requests that require code review awaiting testing For pull requests that require testing labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting code review For pull requests that require code review awaiting testing For pull requests that require testing
Projects
No open projects
Status: New issues/PRs
Development

Successfully merging this pull request may close these issues.

None yet

3 participants