-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angus/remote file requests #2346
Open
veggiesaurus
wants to merge
30
commits into
dev
Choose a base branch
from
angus/remote_file_requests
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Ready for review. Changes:
This PR is currently for the basic features of HiPS data queries. There are some possible enhancements, and I would suggest we file a new issue for them:
|
YuHsuan-Hwang
added
awaiting code review
For pull requests that require code review
awaiting testing
For pull requests that require testing
labels
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting code review
For pull requests that require code review
awaiting testing
For pull requests that require testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP for loading images from hips2fits server
Checklist
For linked issues (if there are):
assignee and label addedZenHub issue connection, board status, and estimate updatedFor the pull request:
For dependencies:
corresponding ICD test fix added (/ no ICD test fix needed (BackendService
changed)BackendService
unchanged)