-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kuanchou/681 relative coordinates #2370
base: dev
Are you sure you want to change the base?
Conversation
@kswang1029 @crocka There is a discussion item. The distance measurement fails when using a relative coordinate, more precisely after applying an AST shifted map. The easiest way is to replace the distance measurement with the ruler annotation. @YuHsuan-Hwang has some concerns about doing that. What's your opinion? |
Do you mean we deprecate the distance measurement tool and ask users to use the rule annotation instead? If so, I am fine with the idea which actually enables multiple measurements and users can see all the results at the same time. |
Yes. I feel the ruler is more useful than the distance measurement. |
I'm ok with deprecating the distance measuring tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very nice! A corresponding fix is applied to an e2e test branch. New tests will be added asap.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks nice. The removal of distance measuring is also good.
Minor comments only:
src/components/ImageView/ImageViewSettingsPanel/ImageViewSettingsPanelComponent.tsx
Outdated
Show resolved
Hide resolved
if (isPVImage) | ||
{ | ||
double corner[] = {xtran[1], ytran[0]}; | ||
plotDistText(wcsinfo, plot, start, corner); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like function plotDistText
could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might old version. I had removed entire if (showCurve) section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I meant the function plotDistText
itself in this file could be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I got it.
UPDATE: Added a corresponding e2e test which checks AST grid rendering including the offset cases. |
…is/carta-frontend into kuanchou/681_relative_coordinates
Description
This PR closes #681 adding an offset coordinates. The offset coordinates consider the projection. We can turn on the offset coordinates using overlay coordinates in the toolbar or the image view setting. The default offset center is the image center and can be customized by setting it to the view center or a manual input. The unit of delta angles changes with the field of view size.
Due to the offset mapping using AST which changes the projection center, the distance measurement went wrong when applying the offset coordinates. Therefore, we replace the distance measurement with the ruler annotation which is not affected by the overlay coordinates.
Checklist
For linked issues (if there are):
For the pull request:
For dependencies:
new e2e test createdprotobuf version bumped/ no protobuf version bumped neededprotobuf updated to the latest dev commit/ no protobuf update neededcorresponding ICD test fix added (/ no ICD test fix needed (BackendService
changed)BackendService
unchanged)user manual prepared (for large new features)