-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yuhsuan/stores null check #2373
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed failed e2e tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we have a spectral profile plot, if we switch the x-axis to "channel", we cannot click a channel to switch to the channel in the image viewer. We cannot zoom/pan the spectral profile plot neither.
This is fixed. |
Description
This PR is for #2343 migrating part of the files in
/stores
to strictNullChecks enabled. The rest of the files in/stores
will be migrated in a separate PR.Some additional changes:
CatalogPlotWidgetStore
fitting
,minMaxX
, andstatistic
: set the entire variable to null instead of setting all members to undefined.PvGeneratorWidgetStore
setSpectralCoordinate
andsetSpectralSystem
.SpectralLineQueryWidgetStore.filters
. Return an array of filter strings instead of an array of headers.SpectralProfileWidgetStore.requestMoment
. Send the info of the selected region (either active or a specific id) instead of the active region.Checklist
For linked issues (if there are):
For the pull request:
changelog updated/ no changelog update neededunit test added (for functions with no dependenies)API documentation added (for public variables and methods in stores)For dependencies:
protobuf version bumped/ no protobuf version bumped neededprotobuf updated to the latest dev commit/ no protobuf update neededBackendService
changed) /no ICD test fix needed (BackendService
unchanged)user manual prepared (for large new features)