Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add post-query options #878

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yankovs
Copy link
Contributor

@yankovs yankovs commented Sep 24, 2023

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • [] I've updated documentation to reflect my change (if applicable)

What is the current behaviour?

Once a query is done, not much can be done with the results. The interface encourages to enter one or a couple of results by hand and continue from there, but doesn't provide a lot of options for operations on a lot of results.

What is the new behaviour?

image

It is far from perfect, but that's the main idea. For queries with 0 results it doesn't show up, and queries that produce too many results can disable some of the options on the dropdown menu by a limit function that can be provided.

Some more work to be done:

  • Fix css, it isn't aligned properly
  • Make code more generic, maybe display different results based on result types. E.g. different stuff for config queries and for blobs
  • Use a more elegant solution than making a context with the query results, and passing the result items around the UI
  • Make sure this scales for a lot of results, I'm talking 100k+ files. For those, the UI shouldn't be slow and sluggish
  • Make sure the Extendable with identity queryResult can handle many elements in it nicely and not start breaking the UI and being weird

Test plan

Try this with a different files, a varied amount of files, and with different actions.

Closing issues

closes #876

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider adding a QueryResultOptions component for actions on query results
1 participant