Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better container support for linux web apps #2

Merged
merged 5 commits into from Jan 14, 2020

Conversation

mcdafydd
Copy link
Contributor

- Variable descriptions clarify valid container and non-container values for `fx` 
- Setting the `fx` variable to `compose` or `kube` triggers base64 encode of `fx_version` variable
- Set default value for storage_accounts variable 
- Add ip_restrictions support in site_config

David McPike added 3 commits January 13, 2020 15:15
- Improve support for docker and compose in linux_fx_version
- Add ip_restrictions block to site_config
@mcdafydd mcdafydd requested a review from tw1984 January 13, 2020 21:30
Copy link
Contributor

@tw1984 tw1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of IP restrictions, I find it helpful if it's clear in the description whether it's an 'allow' or a 'not allowed.'

description = "A list of IP addresses in CIDR format specifying Access Restrictions." Is this an allow or a block?

David McPike added 2 commits January 13, 2020 18:23
  - Clearer variable description
  - Change to dynamic block
@mcdafydd
Copy link
Contributor Author

Thanks for the feedback. I added a test for ip_restriction and clarified its behavior in the variable description.

It looks like there's been an issue open for quite a while to update support for this feature to the latest with support for allow/deny, priority, etc.

hashicorp/terraform-provider-azurerm#2488
hashicorp/terraform-provider-azurerm#4383 (comment)

@mcdafydd mcdafydd merged commit 7ab2a1e into master Jan 14, 2020
@mcdafydd mcdafydd deleted the ip-restrict-and-compose branch January 14, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants