Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3209: AWS Lambda does not support BFD EFT Outbound Lambda Buildx Docker image format #2150

Merged
merged 2 commits into from Jan 18, 2024

Conversation

malessi
Copy link
Contributor

@malessi malessi commented Jan 18, 2024

JIRA Ticket:
BFD-3209

User Story or Bug Summary:

AWS Lambda does not support images built by Buildx (see this GitHub issue), specifically multi-platform images. This is the default type of image built by the suite of Docker image build GitHub Actions, and must be explicitly opted-out of in order to build traditional images. The Build Docker Images Workflow must be updated to build platform-specific images so that the BFD EFT Outbound Lambda (and other Docker image based Lambdas, in the future) can properly take advantage of the Docker images built by this Workflow.

This will cause Deployment Failures if not resolved before Peering Partners enroll in BFD EFT Outbound.


What Does This PR Do?

This PR disables provenance when building Docker Images using Buildx, and explicitly specifies all images built by Build Docker Images be built using the linux/amd64 platform.

I have verified that this resolves the issue by deploying the eft Terraservice with the BFD EFT Outbound Lambda enabled using Docker image generated with these changes.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

  • Verify all PR security questions and checklists have been completed and addressed.

What Security Implications Does This PR Have?

Submitters should complete the following questionnaire:

  • If the answer to any of the questions below is Yes, then you must supply a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence here: N/A

    • Does this PR add any new software dependencies?
      • Yes
      • No
    • Does this PR modify or invalidate any of our security controls?
      • Yes
      • No
    • Does this PR store or transmit data that was not stored or transmitted before?
      • Yes
      • No
  • If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.

    • Do you think this PR requires additional review of its security implications for other reasons?
      • Yes
      • No

What Needs to Be Merged and Deployed Before this PR?

This PR cannot be either merged or deployed until the following prerequisite changes have been fully deployed:

  • N/A

Submitter Checklist

I have gone through and verified that...:

  • I have named this PR and branch so they are automatically linked to the (most) relevant Jira issue. Ie: BFD-123: Adds foo
  • This PR is reasonably limited in scope, to help ensure that:
    1. It doesn't unnecessarily tie a bunch of disparate features, fixes, refactorings, etc. together.
    2. There isn't too much of a burden on reviewers.
    3. Any problems it causes have a small "blast radius".
    4. It'll be easier to rollback if that becomes necessary.
  • This PR includes any required documentation changes, including README updates and changelog / release notes entries.
  • The data dictionary has been updated with any field mapping changes, if any were made.
  • All new and modified code is appropriately commented, such that the what and why of its design would be reasonably clear to engineers, preferably ones unfamiliar with the project.
  • All tech debt and/or shortcomings introduced by this PR are detailed in TODO and/or FIXME comments, which include a JIRA ticket ID for any items that require urgent attention.
  • Reviews are requested from both:
    • At least two other engineers on this project, at least one of whom is a senior engineer or owns the relevant component(s) here.
    • Any relevant engineers on other projects (e.g. DC GEO, BB2, etc.).
  • Any deviations from the other policies in the DASG Engineering Standards are specifically called out in this PR, above.
    • Please review the standards every few months to ensure you're familiar with them.

@malessi malessi enabled auto-merge (squash) January 18, 2024 22:21
@malessi malessi merged commit ee87cc5 into master Jan 18, 2024
6 checks passed
@malessi malessi deleted the alessio/BFD-3209__fix-invalid-docker-build-eft branch January 18, 2024 22:21
mackec1 pushed a commit that referenced this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants