BFD-3209: AWS Lambda does not support BFD EFT Outbound Lambda Buildx Docker image format #2150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3209
User Story or Bug Summary:
AWS Lambda does not support images built by Buildx (see this GitHub issue), specifically multi-platform images. This is the default type of image built by the suite of Docker image build GitHub Actions, and must be explicitly opted-out of in order to build traditional images. The
Build Docker Images
Workflow must be updated to build platform-specific images so that the BFD EFT Outbound Lambda (and other Docker image based Lambdas, in the future) can properly take advantage of the Docker images built by this Workflow.This will cause Deployment Failures if not resolved before Peering Partners enroll in BFD EFT Outbound.
What Does This PR Do?
This PR disables
provenance
when building Docker Images using Buildx, and explicitly specifies all images built byBuild Docker Images
be built using thelinux/amd64
platform.I have verified that this resolves the issue by deploying the
eft
Terraservice with the BFD EFT Outbound Lambda enabled using Docker image generated with these changes.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
If the answer to any of the questions below is Yes, then you must supply a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence here: N/A
If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.
What Needs to Be Merged and Deployed Before this PR?
This PR cannot be either merged or deployed until the following prerequisite changes have been fully deployed:
Submitter Checklist
I have gone through and verified that...:
BFD-123: Adds foo
README
updates and changelog / release notes entries.TODO
and/orFIXME
comments, which include a JIRA ticket ID for any items that require urgent attention.