Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate initialization call from the constructor #63

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

rya-sge
Copy link
Collaborator

@rya-sge rya-sge commented Oct 18, 2022

@rya-sge rya-sge self-assigned this Oct 18, 2022
@rya-sge rya-sge mentioned this pull request Oct 19, 2022
@rya-sge rya-sge requested review from veorq and skrafft October 19, 2022 08:26
@rya-sge
Copy link
Collaborator Author

rya-sge commented Oct 19, 2022

we have to use onlyInitializing in the internal functions and the modifier Initializer in the public function for all contracts.

@rya-sge rya-sge linked an issue Oct 28, 2022 that may be closed by this pull request
@rya-sge rya-sge added the Critical Issue It is very important to fix this issue. label Nov 1, 2022
@veorq veorq merged commit 1987be5 into master Nov 2, 2022
@veorq veorq deleted the fb-initialize-patch-only branch November 2, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Issue It is very important to fix this issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy Breaking Change
2 participants