Abstract row_field #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrigue
force-pushed
the
always_row_repr
branch
from
b78b621
to
286b235
Compare
garrigue
force-pushed
the
abstract_row_field
branch
from
8158900
to
6cd3394
Compare
garrigue
force-pushed
the
always_row_repr
branch
from
45d3fed
to
a2aa59b
Compare
garrigue
force-pushed
the
abstract_row_field
branch
from
6cd3394
to
c889623
Compare
* always row_repr * remove the dummy field `row_bound` Co-authored-by: Takafumi Saikawa <tscompor@gmail.com>
garrigue
force-pushed
the
abstract_row_field
branch
from
c889623
to
26a65bc
Compare
|
Made it a PR on trunk: ocaml#10627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstract the type representation of polymorphic variant row fields, to ensure that only their normal form can be accessed.