Updated discord dependencies and added Minecraft library and some documentation #11
Conversation
- Put player listeners into its own class.
- This will help with tab completing commands.
There was a problem hiding this comment.
Hey there! Thank you for taking the time to work on this PR :D really sorry for the delay in getting back, I was only just tasked recently with checking the plugin and ensuring it's still good for use.
A lot of this looks brilliant, but I did have some concerns with adding Cozy-Library - I know you did work on it, but for the sake of maintenance, I'm not a big fan of relying on external libraries unless it's for a specific function that can't already be done with the standard API. Whilst the command API is a lot more convenient, it may be better suited for larger plugins that manage a lot of commands than a smaller one that just has a single command. We're also not very familiar with your library, so it'd become a bit more difficult for us to maintain than if we were more familiar with the normal Spigot/Paper API. (Hence the million library mods on Curseforge)
Other committee members may disagree with me so don't take my word as gospel, but that's just my two cents!
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.8.1</version> | ||
| <configuration> | ||
| <source>14</source> | ||
| <target>14</target> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-shade-plugin</artifactId> | ||
| <version>3.2.4</version> | ||
| <executions> | ||
| <execution> | ||
| <phase>package</phase> | ||
| <goals> | ||
| <goal>shade</goal> | ||
| </goals> | ||
| <configuration> | ||
| <createDependencyReducedPom>false</createDependencyReducedPom> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| <resources> | ||
| <resource> | ||
| <directory>src/main/resources</directory> | ||
| <filtering>true</filtering> | ||
| </resource> | ||
| </resources> | ||
| </build> |
There was a problem hiding this comment.
Out of curiosity, how come this was moved to the bottom? It may seem a bit nitpicky, but I'm genuinely curious since I've often seen these above dependencies/repositories!
There was a problem hiding this comment.
I'm with Holly here. The plugin library doesn't really seem to improve the code quality which would be what I would look for. For example with the command - it just replaces the Spigot boilerplate with different boilerplate.
Also, it is generally convention to name utility classes with Util rather than Utility.
Finally, I would generally avoid using legacy colour codes at all costs. Whether you just use ChatColor or you use Adventure Components it's up to you, but legacy colour codes decrease readability a lot.
I kinda got carried away with changes so don't worry if you rather not merge!
Let me know if you would like any features, I love making Minecraft plugins :D
Changes:
If you have multiple servers with a proxy, I have a velocity plugin called leaf if you want to check it out, very customisable and has discord webhook support! So could change over to leaf for join leave events ect 馃槑