Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for kill command #203

Merged
merged 3 commits into from May 11, 2024
Merged

Update docs for kill command #203

merged 3 commits into from May 11, 2024

Conversation

MattyTheHacker
Copy link
Member

No description provided.

@CarrotManMatt CarrotManMatt added bug Something isn't working documentation Improvements or additions to documentation labels May 9, 2024
@CarrotManMatt
Copy link
Member

Could you share the reasoning for removing that check? How did you know it was that one that was dodgy? What issues was it causing? Do you know why it didn't perform as expected? What was the values of the variables instead?

@MattyTheHacker
Copy link
Member Author

was just fucking around with it putting logging in different places and realised it never actually passed that block cos that check wasn't passing, tried removing it and it works fine.

iirc the comparison was a Message object to an Interaction object, so it was just permanently failing.

CarrotManMatt
CarrotManMatt requested changes May 9, 2024
View reviewed changes
Copy link
Member

@CarrotManMatt CarrotManMatt left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I see. That's because confirmation_message has type discord.Message | discord.Interaction. It is important for us to perform this check so that we do not incorrectly assume confirmation because of a button press in the same channel that is wholly unrelated.

cogs/kill.py Outdated Show resolved Hide resolved
@CarrotManMatt CarrotManMatt added the suspended Delayed until a later date label May 11, 2024
@CarrotManMatt
Copy link
Member

This is now dependent upon #202

@CarrotManMatt CarrotManMatt changed the title Update docs and remove dodgy check for kill command Update docs for kill command May 11, 2024
@CarrotManMatt CarrotManMatt removed the bug Something isn't working label May 11, 2024
@MattyTheHacker MattyTheHacker merged commit d4acdbd into main May 11, 2024
8 checks passed
@MattyTheHacker MattyTheHacker deleted the fix-kill-command-bug branch May 11, 2024 16:14
@CarrotManMatt CarrotManMatt removed the suspended Delayed until a later date label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LMBishop LMBishop LMBishop approved these changes

@CarrotManMatt CarrotManMatt CarrotManMatt approved these changes

Assignees

@CarrotManMatt CarrotManMatt

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MattyTheHacker @CarrotManMatt @LMBishop