IconButton: make onClick required & fix modal close issue

Cambly · Mar 26, 2024 · 919355c · 919355c
1 parent 9ecadcb
commit 919355c
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/ninety-rice-repair.md b/.changeset/ninety-rice-repair.md
@@ -0,0 +1,5 @@
+---
+"@cambly/syntax-core": minor
+---
+
+IconButton: make onClick required & fix modal close issue
diff --git a/packages/syntax-core/src/IconButton/IconButton.tsx b/packages/syntax-core/src/IconButton/IconButton.tsx
@@ -98,7 +98,7 @@ type IconButtonProps = {
   /**
    * The callback to be called when the button is clicked
    */
-  onClick?: React.MouseEventHandler<HTMLButtonElement>;
+  onClick: React.MouseEventHandler<HTMLButtonElement>;
   /**
    * The tooltip to be displayed when the user hovers over the button
    */

diff --git a/packages/syntax-core/src/Modal/Modal.tsx b/packages/syntax-core/src/Modal/Modal.tsx
@@ -215,13 +215,14 @@ export default function Modal({
                       accessibilityLabel={accessibilityCloseLabel}
                       color={image ? "primary" : "tertiary"}
                       on={image ? "darkBackground" : "lightBackground"}
+                      onClick={onDismiss}
                       size="sm"
                       icon={XIconCambio}
                     />
                   </Box>
                 )}
               </Box>
-              {image && <Box maxHeight={200}>{image}</Box>}
+              {image && <Box>{image}</Box>}
               <Box
                 display="flex"
                 gap={themeName === "classic" ? 3 : 4}