Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: update primary button to Cambio #293

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/syntax-core/src/Button/Button.module.css
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
flex-direction: row;
align-items: center;
justify-content: center;
border-radius: 999px;
}

.buttonGap {
Expand Down Expand Up @@ -55,21 +56,18 @@
min-width: 52px;
height: 32px;
padding: 0 12px;
border-radius: 8px;
}

.md {
min-width: 72px;
height: 40px;
padding: 0 16px;
border-radius: 12px;
}

.lg {
min-width: 88px;
height: 48px;
padding: 0 20px;
border-radius: 16px;
}

.icon {
Expand Down
4 changes: 1 addition & 3 deletions packages/syntax-core/src/Button/Button.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,7 @@ const Button = forwardRef<HTMLButtonElement, ButtonProps>(
size={textVariant[size]}
color={foregroundTypographyColor(color)}
>
<span style={{ fontWeight: 500 }}>
{loading ? loadingText : text}
</span>
{loading ? loadingText : text}
</Typography>
</Box>
)}
Expand Down
1 change: 1 addition & 0 deletions packages/syntax-core/src/colors/backgroundColor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default function backgroundColor(color: (typeof Color)[number]): string {
case "tertiary":
case "destructive-tertiary":
return styles.whiteBackgroundColor;
case "primary":
case "branded":
return styles.yellow700BackgroundColor;
case "inverse":
Expand Down
1 change: 1 addition & 0 deletions packages/syntax-core/src/colors/foregroundColor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ export default function foregroundColor(color: (typeof Color)[number]): string {
case "destructive-secondary":
case "destructive-tertiary":
return styles.destructive700Color;
case "primary":
case "branded":
return styles.gray900Color;
case "inverse":
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export default function foregroundTypographyColor(
case "destructive-secondary":
case "destructive-tertiary":
return "destructive-primary";
case "primary":
case "branded":
return "gray900";
case "inverse":
Expand Down
2 changes: 1 addition & 1 deletion packages/syntax-design-tokens/tokens/color/base.json
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"100": { "value": "#FDF5D9" },
"200": { "value": "#FBE8A3" },
"300": { "value": "#F8D663" },
"700": { "value": "#FFC929" },
"700": { "value": "#ffe14c" },
"800": { "value": "#765F1C" },
"900": { "value": "#3B3009" }
},
Expand Down