Typography/Heading: add Cambio options & styles #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c6ad56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
christianvuerings
force-pushed
the
cambio-typography-heading
branch
from
08ed3f7
to
18aa111
Compare
christianvuerings
force-pushed
the
cambio-typography-heading
branch
from
18aa111
to
63899e4
Compare
christianvuerings
requested review from
ajmooo,
jliotta,
btorndorff,
zprong and
williamnewman94
christianvuerings
force-pushed
the
cambio-typography-heading
branch
from
63899e4
to
e64df9e
Compare
christianvuerings
force-pushed
the
cambio-typography-heading
branch
from
e64df9e
to
c4a83fa
Compare
somethiiing
reviewed
Mar 4, 2024
| @@ -21,28 +21,43 @@ export default { | |||
| control: { type: "radio" }, | |||
| }, | |||
| color: { | |||
| // | "gray900" | |||
zprong
approved these changes
Mar 4, 2024
Comment on lines
24
to
32
| // | "gray900" | ||
| // | "gray700" | ||
| // | "primary" | ||
| // | "destructive-primary" | ||
| // | "destructive-darkBackground" | ||
| // | "success" | ||
| // | "success-darkBackground" | ||
| // | "white" | ||
| // | "inherit", |
There was a problem hiding this comment.
is this comment block intentional? If so, is it meant to maintain documentation on classic colors?
There was a problem hiding this comment.
@zprong removed - thank you
somethiiing
approved these changes
Mar 4, 2024
christianvuerings
force-pushed
the
cambio-typography-heading
branch
from
c4a83fa
to
6c6ad56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Follow up to #317 which added a
ThemeProviderand initial Cambio button styles. In this PR we add Cambio styles forTypography&HeadingChanges
elevationwhen Cambio theme is selectedVideo
cambio-typography-heading.mp4