RichSelectList: update color and make label optional #330
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,3 +2,7 @@ | |
| .richSelectBox:focus-visible { | ||
| outline: none; | ||
| } | ||
|
|
||
| .label { | ||
| cursor: pointer; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ import React, { | |
| useMemo, | ||
| type SyntheticEvent, | ||
| useRef, | ||
| useId, | ||
| } from "react"; | ||
| import classNames from "classnames"; | ||
| import { | ||
|
|
@@ -59,7 +60,9 @@ export type RichSelectListProps = Omit< | |
| /** Text shown below select box */ | ||
| helperText?: string; | ||
| /** Text shown above select box */ | ||
| label?: string; | ||
| //** */ | ||
|
There was a problem hiding this comment. @jliotta instead of adding new The way folks can then add a label, is by adding a custom label outside of RichSelectList: syntax/packages/syntax-core/src/TextField/TextField.tsx Lines 91 to 92 in 09370d9 |
||
| accessibilityLabel: string; | ||
| /** | ||
| * Text showing in select box if no option has been chosen. | ||
| * There should always have a placeholder unless there is a default option selected | ||
|
|
@@ -107,6 +110,7 @@ function RichSelectList(props: RichSelectListProps): ReactElement { | |
| errorText, | ||
| helperText, | ||
| label, | ||
| accessibilityLabel, | ||
| onChange, | ||
| onClick = NOOP, | ||
| placeholderText, | ||
|
|
@@ -117,6 +121,7 @@ function RichSelectList(props: RichSelectListProps): ReactElement { | |
| ...richSelectBoxProps | ||
| } = props; | ||
|
|
||
| const id = useId(); | ||
|
There was a problem hiding this comment. See syntax/packages/syntax-core/src/TextField/TextField.tsx Lines 91 to 92 in 09370d9 |
||
| const isHydrated = useIsHydrated(); | ||
| const disabled = !isHydrated || disabledProp; | ||
|
|
||
|
|
@@ -186,14 +191,20 @@ function RichSelectList(props: RichSelectListProps): ReactElement { | |
| setInteractionModality("keyboard"); // Show the focus ring so the user knows where focus went | ||
| }} | ||
| > | ||
| {label && ( | ||
| <label className={styles.label} htmlFor={id}> | ||
| <Box paddingX={1}> | ||
| <Typography size={100} color="gray700"> | ||
| {label} | ||
| </Typography> | ||
| </Box> | ||
| </label> | ||
| )} | ||
| </ReactAriaLabel> | ||
| <Popover | ||
| ref={overlayHandlerRef} | ||
| disabled={disabled} | ||
| accessibilityLabel={accessibilityLabel} | ||
| content={ | ||
| // this Box wrapper is to reapply the padding that was stripped from popover's dialog to show the sticky save/close buttons. Ideally this could be avoided | ||
| <Box | ||
|
|
@@ -207,7 +218,7 @@ function RichSelectList(props: RichSelectListProps): ReactElement { | |
| selectedValues={selectedKeys} | ||
| defaultSelectedValues={defaultSelectedKeys} | ||
| onChange={(selected) => setSelectedKeys(new Set(selected))} | ||
| accessibilityLabel={accessibilityLabel} | ||
| {...richSelectBoxProps} | ||
| > | ||
| {children} | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jliotta could you make sure to add a changeset to this PR?
pnpm run changeset