RichSelectList: fix classic & cambio styling #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: be09ef5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -61,7 +62,7 @@ export type RichSelectListProps = RichSelectBoxProps & { | |||
| */ | |||
| id?: string; | |||
| /** Text shown above select box */ | |||
| label?: string; | |||
| label: string; | |||
There was a problem hiding this comment.
@jliotta label should still be required but it can be an empty string. When it is an empty string, the label won't render
| })} | ||
| > | ||
| <ReactAriaLabel |
There was a problem hiding this comment.
ReactAriaLabel renders a label and we rendered a label inside of it. Fix that
christianvuerings
force-pushed
the
richselectlist-fix-styling
branch
from
496a9eb
to
be09ef5
Compare
|
Awesome thank you @christianvuerings ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After