Cambio updates after bugbash #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
christianvuerings
commented
Mar 19, 2024
•
christianvuerings
commented
- Bring back elevation
- Avatar & GroupAvatar sizes
- Button icons
- Form elements regular labels
- Checkbox: use cambio specific icon
🦋 Changeset detectedLatest commit: 161f89c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
christianvuerings
force-pushed
the
cambio-after-bug-bash
branch
from
ebe2440
to
ce3280c
Compare
somethiiing
reviewed
Mar 19, 2024
| {checked && themeName === "cambio" && ( | ||
| <svg aria-hidden="true" viewBox="0 0 24 24" width={iconWidth[size]}> | ||
| <path | ||
| fill={error ? "#6d0002" : "#050500"} |
There was a problem hiding this comment.
should these hex values be the color vars?
There was a problem hiding this comment.
@somethiiing thanks for spotting - updated
<svg aria-hidden="true" viewBox="0 0 24 24" width={iconWidth[size]}>
<path
className={error ? styles.checkmarkError : styles.checkmark}
somethiiing
approved these changes
Mar 19, 2024
christianvuerings
force-pushed
the
cambio-after-bug-bash
branch
from
ce3280c
to
161f89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.