Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography: set line-height to initial #343

Merged
merged 1 commit into from Mar 19, 2024

Conversation

christianvuerings
Copy link
Contributor

@christianvuerings christianvuerings commented Mar 19, 2024

We should use line-height: initial for all of our Syntax text https://developer.mozilla.org/en-US/docs/Web/CSS/initial_value

Noticed that we had a global line-height setting in Camblystrap.css which was setting this for all text on Cambly.com

image

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: e9d2434

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cambly/syntax-core Minor
@syntax/storybook Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 10:03pm

@christianvuerings christianvuerings merged commit 64ef7b1 into Cambly:main Mar 19, 2024
10 checks passed
@christianvuerings christianvuerings deleted the typography-initial branch March 19, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant