Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkButton: show icons in Cambio #353

Merged

Conversation

christianvuerings
Copy link
Contributor

@christianvuerings christianvuerings commented Mar 25, 2024

LinkButton Before: no icons show in Cambio

Screenshot 2024-03-25 at 6 15 46 AM

LinkButton After: icons show in Cambio

Screenshot 2024-03-25 at 6 17 05 AM

RichSelectList before: label is not aligned

Screenshot 2024-03-25 at 6 26 36 AM

RichSelectList after: label is aligned

Screenshot 2024-03-25 at 6 32 57 AM

Copy link

changeset-bot bot commented Mar 25, 2024

🦋 Changeset detected

Latest commit: 0e3f1b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@cambly/syntax-core Minor
@syntax/storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 1:33pm

@christianvuerings christianvuerings merged commit e0c8259 into Cambly:main Mar 25, 2024
10 checks passed
@christianvuerings christianvuerings deleted the cambio-link-button-selectlist branch March 25, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant