Modal/FocusTrap: useLayoutEffect #357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00cfd9c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
christianvuerings
force-pushed
the
focus-use-layout-effect
branch
from
2f5fe85
to
00cfd9c
Compare
somethiiing
approved these changes
Mar 25, 2024
btorndorff
approved these changes
Mar 25, 2024
|
Closing this PR since it was fixed by using (the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better fix than #355
In Cambio we use a Cambly Syntax IconButton instead of a custom
buttoncomponent. AnIconButtonis only enabled after hydration / first render so focus on the first element is not possible which caused the previous.focusfailure.How is this better?
Still sets the
focuson the close icon button