Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography: only use GT Super on supported languages #362

Conversation

christianvuerings
Copy link
Contributor

@christianvuerings christianvuerings commented Mar 27, 2024

Background

We currently use a trial version of the GT Super font which only supports a limited set of characters. That causes issues for our users and we should fix it.

Changes

  • Use full version of GT super font (converted OTF => WOFF2 with https://cloudconvert.com/otf-to-woff2)
  • Only use GT Super on supported languages
  • Add Storybook example to show before / after

Before

Screenshot 2024-03-27 at 11 29 16 AM

After

Screenshot 2024-03-27 at 11 30 43 AM

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: a1f9113

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@cambly/syntax-design-tokens Minor
@cambly/syntax-core Minor
@cambly/syntax-floating-components Minor
@syntax/storybook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
syntax ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 6:50pm

@christianvuerings christianvuerings force-pushed the gt-super-only-supported-languages branch from 27d2d1d to a1f9113 Compare March 27, 2024 18:49
@christianvuerings christianvuerings merged commit 272d75c into Cambly:main Mar 27, 2024
10 checks passed
@christianvuerings christianvuerings deleted the gt-super-only-supported-languages branch March 28, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants