Icons: fix having to import from /dist #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 39ec05b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -1,7 +1,7 @@ | |||
| import { type StoryObj, type Meta } from "@storybook/react"; | |||
| import Badge from "./Badge"; | |||
| import RepeatIcon from "@mui/icons-material/Repeat"; | |||
| import Refresh from "../../../syntax-icons/src/Refresh"; | |||
| import Refresh from "../../../syntax-icons/src/icons/Refresh"; | |||
There was a problem hiding this comment.
@somethiiing moved these into icons to be able to quickly get a list of all the different icons (excluding tests / stories or other files)
There was a problem hiding this comment.
oh man, i wanted to do this before, but i remember you wanted to keep it flatter in core so i kept it this way
| import path from "node:path"; | ||
|
|
||
| describe("package.json: exports", () => { | ||
| it("contains correct exports", async () => { |
There was a problem hiding this comment.
@somethiiing added a test to ensure we use have the correct exports field
christianvuerings
requested review from
jliotta,
btorndorff,
zprong and
williamnewman94
zprong
approved these changes
May 14, 2024
somethiiing
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this a breaking change?
Previous imports including
/distwill no longer work, example change when this lands:Why is this no longer an issue in Cambly-Frontend
Since we now use a new module resolution: https://github.com/Cambly/Cambly-Frontend/pull/9878
Notes