Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix .mjs extension removal #5

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

danielfalk
Copy link
Contributor

This fixes an installation error with mise (possibly affects asdf as well?):

mv: cannot move '.local/share/mise/installs/ni/0.21.12/bin/na.mjs' to '.local/share/mise/installs/ni/0.21.12/bin/na/': Not a directory

Mise is intended as a drop-in replacement for asdf, but installing ni fails while trying to remove the .mjs extension. I would imagine asdf fails as well but I don't have that installed anymore.

This fix worked for me, so I thought I'd contribute it back

This fixes an installation error with mise (possibly affects asdf as well?):

mv: cannot move '.local/share/mise/installs/ni/0.21.12/bin/na.mjs' to '.local/share/mise/installs/ni/0.21.12/bin/na/': Not a directory
@danielfalk danielfalk changed the title Fix .mjs extension removal fix: Fix .mjs extension removal Mar 18, 2024
@CanRau CanRau merged commit 442d58b into CanRau:main Mar 19, 2024
0 of 2 checks passed
CanRau added a commit that referenced this pull request Mar 19, 2024
CanRau added a commit that referenced this pull request Mar 19, 2024
@CanRau
Copy link
Owner

CanRau commented Mar 19, 2024

Hey thank you for the PR.
I guess you're referring to this https://mise.jdx.dev right?
Looks actually pretty interesting, might even switch to mise myself ^^ was just reading the comparison and asdf's shims are my biggest "dislike" as well 👀

@CanRau
Copy link
Owner

CanRau commented Mar 19, 2024

@danielfalk Though wouldn't it be possible to install ni directly via mise's npm backend?

@danielfalk
Copy link
Contributor Author

Thanks for pointing this out. I hadn't seen it. It is experimental, so there's that, but this could be nice!

@CanRau
Copy link
Owner

CanRau commented Mar 20, 2024

Just installed mise via brew then

  1. m settings set experimental true
  2. m use -g npm:@antfu/ni
  3. mx ni --help

Have the following aliases set up

alias m="mise"
alias mx="mise exec --"
alias mr="mise run --"

So seems to work pretty good so far 🥳

Thanks for bringing mise to my attention ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants