Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #130

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Windows support #130

wants to merge 4 commits into from

Conversation

MikeTkachuk
Copy link

@MikeTkachuk MikeTkachuk commented Feb 12, 2024

Disclaimer: It's my first experience with cmake and cuda source, so it's one of the dirties PRs I've ever done. But here is the build that worked for me. Hope this helps somebody run or turn this into a conda-forge package, seems ok for a separate branch
Did not benchmark, but it runs tests.
My setup:

  • Windows (11)
  • Visual Studio 2022 MSVC 19.38. MSBuild version 17.8.3
  • Cuda 11.8
  • conda 23.11.0
  • cmake 3.28.3

See windows.txt file for command reference

@MikeTkachuk MikeTkachuk mentioned this pull request Feb 17, 2024
@DavidMChan
Copy link
Member

Hi @MikeTkachuk - Thanks for this contribution! I'm amazed that you could get it working on Windows! To merge this, we'll have to correctly set the cmake flags dependent on the underlying OS (so as to make this platform agnostic) -- the other changes should be able to be preserved as is, since long is underspecified on linux anyways (and int64_t is probably better). Until then, I'll leave this PR open, so people can use this branch/fork if it works for them!

I'm not entirely sure how to update the conda-forge recipe (https://github.com/conda-forge/tsnecuda-feedstock), since @h-vetinari took care of that for us, but that will have to be updated as well.

@raulmendez
Copy link

Hi @MikeTkachuk: can you please be more explicit? I do not find the windows.txt file, and need a little bit more instructions (by the way I am on Windows 10, not 11).

Thanks!

@MikeTkachuk
Copy link
Author

Hi, this is just a draft of how I made it to work, you can find windows.txt in the PR files. You should still modify a lot of paths until someone has the time to integrate it,
Regards

@raulmendez
Copy link

Thanks @MikeTkachuk : I saw it https://github.com/MikeTkachuk/tsne-cuda/blob/main/windows.txt . I do not understand very well the questions, are they options for cmake?

@MikeTkachuk
Copy link
Author

I reformatted windows.txt file a bit, let me know if it sounds clear now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants